-
Notifications
You must be signed in to change notification settings - Fork 124
Helm: add support for auto upgrading CRDs #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34c2c70
to
3cf7330
Compare
Introduces a pre-upgrade hook that will upgrade/create any of the CRD manifests that are bundled in the vso docker image. Other fixes: - make the component label test more reliable by checking all documents individually. - configure a backoff in the pre-delete "pdcc" Job.
a18272c
to
425f2bc
Compare
425f2bc
to
193d7b9
Compare
03fdd08
to
879d271
Compare
This reverts commit 76aa42b.
0be91a1
to
988ef72
Compare
988ef72
to
44d097c
Compare
tvoran
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor questions, and I'm wondering if we need to check the Status
block on upgrades, but on the whole 👍
f5ec297
to
09c51a7
Compare
Tests: - make expected upgrades dynamic based in coming CRDs
09c51a7
to
d088232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a pre-upgrade hook that will upgrade/create any of the CRD manifests that are bundled in the vso docker image.
Other fixes:
Overview of the approach:
Out of scope:
Update to the Helm values: