VSS: use a constant backoff on some reconciliation errors #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the VaultStaticSecretReconciler to use a constant backoff when it encounters specific errors during reconciliation. This is the same approach taken in the VDS and VPS controllers.
benashz
force-pushed
the
VAULT-27993/vss-add-constant-backoff-only-get-client-errors
branch
from
fe6384e to
8a4383d
Compare
benashz
changed the title
thyton
approved these changes
Jun 11, 2024
benashz
deleted the
VAULT-27993/vss-add-constant-backoff-only-get-client-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the VaultStaticSecretReconciler to use a constant backoff when it encounters specific errors during reconciliation. This is the same approach taken in the VDS and VPS controllers.
Previously some reconciliation errors would be passed to the controller's error handling queue, which could lead to very short delays between reconciliation.