Update mholt/archiver to v3.5.1

[stone-z]

Fixes #11591

The current version of archiver has an issue which our dependency analyzer doesn't like and thus blocks our builds from time to time. This PR updates it to v3.5.0.

I've searched existing issues to see if there was a reason it hasn't been updated and didn't find anything, so it seems like it might have just been overlooked. It seems pretty straightforward to update, but I don't work with go mod vendor often so would appreciate a double check there.

Please let me know if you think this PR calls for a separate issue or changelog entry as well - I'd be happy to provide them.

[hashicorp-cla]

All committers have signed the CLA.

[stone-z]

The CI failure seems to be related to timing out building ui, which I wouldn't imagine is related -- maybe a maintainer can retry the job?

#8 [3/3] RUN cd ui && yarn --verbose run build
...
#8 75.03 [BABEL] Note: The code generator has deoptimised the styling of /gopath/src/github.com/hashicorp/vault/ui/node_modules/swagger-ui-dist/swagger-ui-bundle.js as it exceeds the max of 500KB.
packages-oss.lock/layers/layers.mk:66: recipe for target '.buildcache/layers/06-build-ui-993e50cbb3d37120b1391442177827b615c77f82/58a8397e2df5270d582f27c9cfac2dd9cc14a476/image.marker' failed
make: *** [.buildcache/layers/06-build-ui-993e50cbb3d37120b1391442177827b615c77f82/58a8397e2df5270d582f27c9cfac2dd9cc14a476/image.marker] Terminated

Too long with no output (exceeded 10m0s): context deadline exceeded

[stone-z]

cc @calvn @briankassouf as you've been previously involved in debug / this dependency

[stone-z]

Hi folks, am I missing anything here?

[mladlow]

@calvn I changed the milestone on this due to timing - would you mind taking a look and seeing if we could merge it to main?

[stone-z]

@calvn @mladlow can I help here? Seems like an uncontroversial change and it would be really nice to clear the CVE findings from our CI scans

[stone-z]

Ok, so the new go version and default branch change threw me for a bit of a loop, but there's a newer version of archiver so I've updated this PR with the newer version. The failing test seems unrelated (?) so I think this is good to go now

[tsaarni]

Ping :) This PR will remove CVE-2019-10743 (mholt/archiver#169) which is now reported by scanners. It would be great to get this merged!

[calvn]

@stone-z it looks like we have merge conflicts since we've recently updated a bunch of other dependencies. Are you able to resolve them and push an update here?

[stone-z]

@calvn merge conflict has been fixed ✔️

[fairclothjm]

thanks @stone-z for the contribution!