Regression: cannot install some packages with custom setup

[bos]

I'm using recent builds of Cabal:

$ cabal --version
cabal-install version 0.14.0
using version 1.14.0 of the Cabal library 

If I try to install syb now, the installation bails:

$ PATH=/usr/local/ghc/7.2.1/bin:$PATH cabal install syb
Resolving dependencies...
[1 of 1] Compiling Main             ( /tmp/syb-0.3.7-12271/syb-0.3.7/Setup.hs, /tmp/syb-0.3.7-12271/syb-0.3.7/dist/setup/Main.o )

/tmp/syb-0.3.7-12271/syb-0.3.7/Setup.hs:4:30:
    Warning: In the use of `runTests'
             (imported from Distribution.Simple, but defined in Distribution.Simple.UserHooks):
             Deprecated: "Please use the new testing interface instead!"
Linking /tmp/syb-0.3.7-12271/syb-0.3.7/dist/setup/setup ...
unrecognized option `--disable-benchmarks'

The issue is that cabal is invoking syb's setup program with options it doesn't understand.

At the very least --disable-benchmarks isn't working. It's possible that syb would reject --disable-tests too, but that the first error is masking this.

[tibbe]

@ttuegel Would you mind taking a look?

[bos]

I just checked by hand, and it's only --disable-benchmarks that's the problem.

[bos]

I see that bits-atomic is affected by the same problem.

[tibbe]

I'm having a hard time reproducing this:

Making sure I use the same Cabal/cabal-install as you:

$ git checkout -b debug cabal-install-0.14.0
$ cd Cabal
$ cabal clean
cleaning...
$ cabal configure && cabal build
...
$ cd ../cabal-install
$ cabal configure --package-db=../Cabal/dist/package.conf.inplace 
...
$ cabal build
...
$ ~/src/cabal/cabal-install/dist/build/cabal/cabal --version
cabal-install version 0.14.0
using version 1.14.0 of the Cabal library

Installing bits-atomic:

$ ~/src/cabal/cabal-install/dist/build/cabal/cabal --reinstall install bits-atomic
Warning: /Users/tibbe/.cabal/config: Unrecognized field jobs on line 57
Resolving dependencies...
In order, the following will be installed:
bits-atomic-0.1.3 (reinstall)
Warning: Note that reinstalls are always dangerous. Continuing anyway...
[1 of 1] Compiling Main             ( /var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-68239/bits-atomic-0.1.3/Setup.hs, /var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-68239/bits-atomic-0.1.3/dist/setup/Main.o )

/var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-68239/bits-atomic-0.1.3/Setup.hs:2:1:
    Warning: In the use of `runTests'
             (imported from Distribution.Simple, but defined in Distribution.Simple.UserHooks):
             Deprecated: "Please use the new testing interface instead!"
Linking /var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-68239/bits-atomic-0.1.3/dist/setup/setup ...
Configuring bits-atomic-0.1.3...
Building bits-atomic-0.1.3...
Preprocessing library bits-atomic-0.1.3...
[1 of 1] Compiling Data.Bits.Atomic ( Data/Bits/Atomic.hs, dist/build/Data/Bits/Atomic.o )
Registering bits-atomic-0.1.3...
Running Haddock for bits-atomic-0.1.3...
Warning: The documentation for the following packages are not installed. No
links will be generated to these packages: rts-1.0
Preprocessing library bits-atomic-0.1.3...
Haddock coverage:
 100% (  5 /  5) in 'Data.Bits.Atomic'
Documentation created: dist/doc/html/bits-atomic/index.html
Installing library in /Users/tibbe/.cabal/lib/bits-atomic-0.1.3/ghc-7.4.1
Registering bits-atomic-0.1.3...
Updating documentation index /Users/tibbe/.cabal/share/doc/index.html

[tibbe]

Same thing happens if I install Cabal/cabal-install from Hackage:

$ cabal install cabal-install-0.14.0 Cabal-1.14.0
...
$ cabal --version
cabal-install version 0.14.0
using version 1.14.0 of the Cabal library
$ cabal --reinstall install bits-atomic
Resolving dependencies...
In order, the following will be installed:
bits-atomic-0.1.3 (reinstall)
Warning: Note that reinstalls are always dangerous. Continuing anyway...
[1 of 1] Compiling Main             ( /var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-70853/bits-atomic-0.1.3/Setup.hs, /var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-70853/bits-atomic-0.1.3/dist/setup/Main.o )

/var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-70853/bits-atomic-0.1.3/Setup.hs:2:1:
    Warning: In the use of `runTests'
             (imported from Distribution.Simple, but defined in Distribution.Simple.UserHooks):
             Deprecated: "Please use the new testing interface instead!"
Linking /var/folders/4z/7867658n33bckfymwsmh6z8w0000gp/T/bits-atomic-0.1.3-70853/bits-atomic-0.1.3/dist/setup/setup ...
Configuring bits-atomic-0.1.3...
Building bits-atomic-0.1.3...
Preprocessing library bits-atomic-0.1.3...
[1 of 1] Compiling Data.Bits.Atomic ( Data/Bits/Atomic.hs, dist/build/Data/Bits/Atomic.o )
Registering bits-atomic-0.1.3...
Running Haddock for bits-atomic-0.1.3...
Warning: The documentation for the following packages are not installed. No
links will be generated to these packages: rts-1.0
Preprocessing library bits-atomic-0.1.3...
Haddock coverage:
 100% (  5 /  5) in 'Data.Bits.Atomic'
Documentation created: dist/doc/html/bits-atomic/index.html
Installing library in /Users/tibbe/.cabal/lib/bits-atomic-0.1.3/ghc-7.4.1
Registering bits-atomic-0.1.3...
Updating documentation index /Users/tibbe/.cabal/share/doc/index.html

[bos]

Well huh. Cabal and cabal-install swore they were the versions they claimed, but I rebuilt both, and now everything works. That's deeply weird.

[tibbe]

What might have happened is that because we don't bump the versions numbers until just before a release, a build from HEAD, made after e.g. 1.14.0 was made, will be identified as 1.14.0.

[bos]

Wait, it's still a problem: https://jenkins.serpentine.com/job/text/83/ghc_version=7.2.1/console

[bos]

This seems to be specific to GHC 7.2.1, though?

[tibbe]

Each GHC has its own version of Cabal the library installed. Could you check which one is used by your 7.2.1. Perhaps the custom Setup is linking against an older Cabal than we thing?

[tibbe]

Perhaps you could build using just the bits-atomic package using -v3 so we can see exactly which libraries are picked up. My suspicion is that the Cabal that shipped with 7.2.1 didn't support benchmarks, but the cabal binary you're using does.

[bos]

Perhaps you could build using just the bits-atomic package using -v3 so
we can see exactly which libraries are picked up. My suspicion is that the
Cabal that shipped with 7.2.1 didn't support benchmarks, but the cabal
binary you're using does.

That seems quite likely. Does that mean I need to build the newest Cabal
separately for each version of GHC I have installed? That's not much
trouble. I'll give it a try.

[tibbe]

That seems quite likely. Does that mean I need to build the newest Cabal separately for each version of GHC I have installed? That's not much trouble. I'll give it a try.

I'd like that to not be the case (and we might be able to change things so that's not the case), but feel free to try it out and report back.

[23Skidoo]

I stumbled into this issue a while ago, and IIRC it is caused by the line configBenchmarks = toFlag False in installConfiguredPackage in Distribution.Client.Install. This field should be set to NoFlag if the Cabal version that the Setup.hs uses is too old.

[23Skidoo]

Possible duplicate: #932

[tibbe]

Fixed by 582d12e.

[rrnewton]

FYI, my Jenkins also ran into this with GHC 7.2.2 on "haskell-src-exts". This was using a single cabal binary across all GHC versions (cabal-install 1.16.0.2). I'll see if Cabal HEAD fixes it.

http://tester-lin.soic.indiana.edu:8080/job/HackageReleased_monad-par/GHC_VERS=7.2.2,label=linux/7/console

I couldn't quite make out from the above exchange -- @bos, did you get things to work by building a separate cabal with each GHC?