Don't pass unsupported flags to setups built with old Cabal versions. #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not pass '--disable-benchmarks' to setup scripts built with Cabal < 1.14; the same is also true for '--disable-tests' and Cabal < 1.10. Fixes haskell#932 and haskell#1004. Without this patch: $ cabal install -w /path/to/ghc-7.2.1/bin/ghc syb [...] unrecognized option `--disable-benchmarks' Failed to install syb-0.3.7 With this patch: $ cabal install -w /path/to/ghc-7.2.1/bin/ghc syb [...] Registering syb-0.3.7... Installed syb-0.3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not pass
--disable-benchmarksto setup scripts built with Cabal < 1.14; the same is also true for--disable-testsand Cabal < 1.10.Fixes #932 and #1004.
Without this patch:
With this patch: