Skip to content

"Build profile" message doesn't reflect optimization setting from ~/.cabal/config #8487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses4ever opened this issue Sep 20, 2022 · 5 comments · Fixed by #8488
Closed

Comments

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Sep 20, 2022

Originally posted by @mouse07410 in #6221 (comment)

The title says it all. I checked that the optimization: 2 in the global config is not reflected, but the local packages respect it (unless it was overridden down the line -- in cabal.project(.local) or .cabal files). It's not hard to fix. I could take it if there's no objections.

ulysses4ever added a commit that referenced this issue Sep 20, 2022
It still reports local config's optimization level if it was set.

Fix #8487.
@mouse07410
Copy link
Collaborator

Objections? I think a fix should be welcome!

@ulysses4ever
Copy link
Collaborator Author

PR is posted #8488

ulysses4ever added a commit that referenced this issue Sep 20, 2022
It still reports local config's optimization level if it was set.

Fix #8487.
ulysses4ever added a commit that referenced this issue Sep 21, 2022
It still reports local config's optimization level if it was set.

Fix #8487.
ulysses4ever added a commit that referenced this issue Sep 21, 2022
It still reports local config's optimization level if it was set.

Fix #8487.
@Mikolaj
Copy link
Member

Mikolaj commented Sep 24, 2022

@mouse07410: could you kindly review, given that this PR is based on your input?

@Mikolaj
Copy link
Member

Mikolaj commented Sep 24, 2022

Edit: ideally, test locally and review.

@Mikolaj
Copy link
Member

Mikolaj commented Sep 24, 2022

Edit: wrong window. :)

andreabedini pushed a commit that referenced this issue Oct 1, 2022
It still reports local config's optimization level if it was set.

Fix #8487.
@mergify mergify bot closed this as completed in #8488 Oct 1, 2022
alexbiehl pushed a commit to alexbiehl/cabal that referenced this issue Dec 15, 2022
It still reports local config's optimization level if it was set.

Fix haskell#8487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants