"Build profile" now reflects optimization level set in global config

[ulysses4ever]

It still reports local config's optimization level if it was set.

Fix #8487.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[jneira]

Looks great, a good ux improvement with minimal code
I would add a regression test, i hope it will not be too difficult. And the usual changelog entry

[ulysses4ever]

@jneira thanks for the feedback! Test and changelog added.

[jneira]

lgtm, thanks

[Mikolaj]

@mouse07410: could you kindly review, given that this PR is based on your input?

[ulysses4ever]

@mouse07410 To test locally, it may be sufficient to download the cabal binary built by the CI run for this PR. At the very bottom of this page you can find the binaries for the three main platforms.

[mouse07410]

I confirm that cabal-macOS-9.2.3 works as expected (within my limited tests) on MacOS Monterey with GHC-9.4.2, displaying the correct "Build profile":

$ cabal-macOS-9.2.3 build
Warning: this is a debug build of cabal-install with assertions enabled.
Resolving dependencies...
Build profile: -w ghc-9.4.2 -O2
In order, the following will be built (use -v for more details):
 - stepic-tests-0.1.0.0 (lib) (first run)
.  .  .

I tried to post a review, but couldn't figure how to do it - it does not seem to let me, even after I joined the "cabal" organization (no pun intended ;)).

[mouse07410]

Tested on my Mac (with GHC-9.4.2), works as expected. Note: my testing was pretty limited.

[ulysses4ever]

@mouse07410 thank you!

@Mikolaj do you know what’s up with permissions for @mouse07410? In the list of approvals for this PR, I see a gray check mark for them and a green one for jneira, and CI says that there’s only one approval…

[Mikolaj]

@Mikolaj do you know what’s up with permissions for @mouse07410? In the list of approvals for this PR, I see a gray check mark for them and a green one for jneira, and CI says that there’s only one approval…

It must be what the Triage permission level enables, the one I was advised to grant by default unless a higher level is explicitly required. That's quite unfortunate...

[Mikolaj]

@mouse07410, I've promoted you to authority level WRITE. Use your new-found powers well. :)

[mouse07410]

I've promoted you to authority level WRITE. Use your new-found powers well. :)

Thank you!

I think I need to do a lot of READ before I can contemplate WRITE. ;-)

[mouse07410]

I did a couple more tests - specifically, explicit settings in ~/.cabal/config and $PROJECT_HOME/cabal.project.local. Worked as expected (correctly).

I don't recall if optimization: N has to go to cabal.project or cabal.project.local - or it's possible to define in <project>.cabal file?

[Mikolaj]

I don't recall if optimization: N has to go to cabal.project or cabal.project.local - or it's possible to define in <project>.cabal file?

At least optimization: False is legal in cabal.project and cabal.project.local (I haven't tried a number there). I set it in <project>.cabal via ghc-options: -O2, so I'm not sure if it can be done more natively there.

[ulysses4ever]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased