Skip to content

Show Version returning "mkVersion [...]" #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2016
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Oct 11, 2016

With tests,

as an extra improved NubList properties (it had a typo, so added few properties there as well)

@mention-bot
Copy link

@phadej, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ddssff, @dcoutts and @hvr to be potential reviewers.

@23Skidoo
Copy link
Member

Looks OK.

Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phadej phadej force-pushed the version-show branch 2 times, most recently from 7ee5bfb to 01cabde Compare October 11, 2016 16:41
@phadej phadej merged commit 0ce2dba into haskell:master Oct 12, 2016
@phadej phadej deleted the version-show branch October 12, 2016 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants