Adapt to changes in Distribution.Version. #3967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DEBUG_TRACETREE debugging feature of cabal-install still had a call to 'showVersion' in it, which has been removed by recent changes to 'Distribution.Version'.
|
@kosmikus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edsko, @grayjay and @BardurArantsson to be potential reviewers. |
|
partially related, |
|
ping @hvr |
|
I canceled the CI builds, since our CI currently doesn't exercise this code path (which is why the issue went unnoticed). |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DEBUG_TRACETREE debugging feature of cabal-install
still had a call to 'showVersion' in it, which has been
removed by recent changes to 'Distribution.Version'.