Skip to content

Add Travis job to build cabal with solver debug flags enabled. #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

grayjay
Copy link
Collaborator

@grayjay grayjay commented Oct 16, 2016

The job should detect issues like #3967.

@mention-bot
Copy link

@grayjay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezyang, @phadej and @23Skidoo to be potential reviewers.

@ezyang
Copy link
Contributor

ezyang commented Oct 16, 2016

Re sandbox, is this fundamentally a problem with how new-build works (i.e., would new-build work if we did it with HEAD?) Can we do something about the deps?

@grayjay
Copy link
Collaborator Author

grayjay commented Oct 16, 2016

The dependencies' setup scripts don't compile with Cabal HEAD, so we would have to force an older Cabal version. new-build at HEAD succeeds, because the dependencies lack custom-setup stanzas, and new-build adds a default setup dependency on Cabal < 1.25 (cabal-install 1.24 only constrains it to 2.0). I think that the best solution would be to use qualified constraints (#3502) in cabal.project, once they are available.

@ezyang
Copy link
Contributor

ezyang commented Oct 16, 2016

Heh, oh the pains of being Cabal (maybe this behavior makes sense for other people, but it definitely doesn't make sense for us!)

@grayjay
Copy link
Collaborator Author

grayjay commented Oct 16, 2016

Yeah, Cabal definitely seems like a special case.

@phadej
Copy link
Collaborator

phadej commented Oct 16, 2016

(FWIW, similar issue as compiling with -fparsec-struct-diff... cannot do that with 1.24 new-build)

@grayjay grayjay force-pushed the travis-solver-debug-flags branch from 83ac0ff to df54fe2 Compare October 16, 2016 16:01
@grayjay
Copy link
Collaborator Author

grayjay commented Oct 16, 2016

(FWIW, similar issue as compiling with -fparsec-struct-diff... cannot do that with 1.24 new-build)

Maybe we should apply #3939 to 1.24.

@23Skidoo
Copy link
Member

Maybe we should apply #3939 to 1.24.

Done: 7ba7489.

@23Skidoo 23Skidoo merged commit aafcb33 into haskell:master Oct 17, 2016
@23Skidoo
Copy link
Member

Merged, thanks!

@grayjay
Copy link
Collaborator Author

grayjay commented Oct 18, 2016

Thanks!

@grayjay grayjay deleted the travis-solver-debug-flags branch October 18, 2016 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants