Skip to content

cabal-install.cabal: bump hashable, HTTP, time upper bounds #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022

Conversation

juhp
Copy link
Collaborator

@juhp juhp commented May 2, 2022


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

Tested against 3.6.2.0 so far

@andreasabel
Copy link
Member

andreasabel commented May 2, 2022

There is a CI failure for Validate Windows GHC 8.10.7:
https://github.com/haskell/cabal/runs/6255134538?check_suite_focus=true#step:14:49

PackageTests\Configure\cabal.test.hs                                                                              FAIL (0.02s)
$ "C:\tools\ghc-8.10.7\bin\runghc.exe" "--" 
"--ghc-arg=-i" "--ghc-arg=-no-user-package-db" 
"--ghc-arg=-package-db" "--ghc-arg=C:\sr\ghc-8.10.7\package.db" 
"--ghc-arg=-package-db" "--ghc-arg=D:\a\cabal\cabal\dist-newstyle-validate-ghc-8.10.7\packagedb\ghc-8.10.7" 
"--ghc-arg=-package-id" "--ghc-arg=Cabal-3.7.0.0-inplace" 
"--ghc-arg=-package-id" "--ghc-arg=Cabal-syntax-3.7.0.0-inplace" 
"--ghc-arg=-package-id" "--ghc-arg=async-2.2.4-868bcb0b8bfbd5dabae6059e02c90868c75826f5" 
"--ghc-arg=-package-id" "--ghc-arg=base-4.14.3.0" 
"--ghc-arg=-package-id" "--ghc-arg=cabal-testsuite-3-inplace" 
"--ghc-arg=-package-id" "--ghc-arg=clock-0.8.3-8d6f0308588d4c62899853cf2a200407866d2820" 
"--ghc-arg=-package-id" "--ghc-arg=exceptions-0.10.4" 
"--ghc-arg=-package-id" "--ghc-arg=filepath-1.4.2.1" 
"--ghc-arg=-package-id" "--ghc-arg=optparse-appl_-0.16.1.0-06e1a7c9966dfac15712d8a0c66d2bc0900408e0" 
"--ghc-arg=-package-id" "--ghc-arg=process-1.6.14.0-e20921632eca8df7ccd15140aea02df6df51aa92" 
"--ghc-arg=-package-id" "--ghc-arg=transformers-0.5.6.2" "PackageTests\Configure\cabal.test.hs" 
"--builddir" "D:/a/cabal/cabal/dist-newstyle-validate-ghc-8.10.7/build/x86_64-windows/ghc-8.10.7/cabal-testsuite-3" "PackageTests\Configure\cabal.test.hs" 
"--with-ghc" "ghc"
stdout:

stderr:

PackageTests\Configure\cabal.test.hs:4:1: error:
Error:     Ambiguous module name ‘System.Directory’:
      it was found in multiple packages:
      directory-1.3.7.0 directory-1.3.7.0
  |
4 | import System.Directory
  | ^^^^^^^^^^^^^^^^^^^^^^^

Doesn't look related. I try and restart.

@juhp juhp changed the title cabal-install.cabal: allow time-1.11 cabal-install.cabal: bump hashable, HTTP, time upper bounds May 2, 2022
@juhp
Copy link
Collaborator Author

juhp commented May 2, 2022

Like #8118 these should also be done as revisions to 3.6.2.0.

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo CI passing.

@Mikolaj
Copy link
Member

Mikolaj commented May 2, 2022

Like #8118 these should also be done as revisions to 3.6.2.0.

I will revise on hackage if tests pass on master, given these are not as fundamental as package base, so testing 3.6 branch specifically is not that crucial IMHO.

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label May 2, 2022
@mergify mergify bot merged commit 02951dc into master May 2, 2022
@juhp
Copy link
Collaborator Author

juhp commented May 2, 2022

Thanks!

@juhp juhp deleted the juhp-patch-1 branch May 2, 2022 14:01
@jneira
Copy link
Member

jneira commented May 2, 2022

Hmm, the ci was failed when mergify merged the pr, again 🤔
The error is weird:

PackageTests\PreProcess\Hsc2HsOptionsCC\setup.test.hs:4:1: error:
Error:     Ambiguous module name ‘System.Directory’:
      it was found in multiple packages:
      directory-1.3.7.0 directory-1.3.7.0
  |
4 | import System.Directory (findExecutable)
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

maybe another cache issue?

The three last commits on master has failed with the same error.
I am investigating on how to avoid the skipping of the post job

@andreasabel andreasabel mentioned this pull request May 3, 2022
jneira added a commit to jneira/cabal that referenced this pull request May 4, 2022
This reverts commit 02951dc, reversing
changes made to 3a0989d.
jneira added a commit to jneira/cabal that referenced this pull request May 4, 2022
This reverts commit 02951dc, reversing
changes made to 3a0989d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants