-
Notifications
You must be signed in to change notification settings - Fork 711
Run always validate post-job #8122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by Mergify behaviour. Let's hope this fixes it.
Before this PR can be merged, the workflow Validate windows-latest ghc-8.10.7 needs to be fixed, to satisfy self-application:
;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. But I'm confused by the CI failure.
@Mergifyio rebase |
✅ Branch has been successfully rebased |
85d36d3
to
5b8548e
Compare
Oh, I see @jneira has spotted the same problem already here: #8120 (comment) |
well, I think we have to merge this asap to avoid more bad merges |
then we have to tackle the cause of the error, I think the pr bumping versions was |
To make mergify not merge prs with failing validate jobs
5b8548e
to
1ff106b
Compare
we have a succesul run in master after the pr so it probably will not be: https://github.com/haskell/cabal/actions/runs/2268699392 |
I agree, let's merge. We won't forget to fix the failing tests, because they are failing. Oh, wait, CI passed right now, after a rebase. ??? |
And here it's now reported good even without a rebase: #8109 |
yeah, the error has been transient, so maybe due to a bad cache 🤷 |
To make mergify not merge prs with failing validate jobs
If a main validate job fails github marks as skipped the rest of workflow jobs.
Otoh mergify considers prs with skipped required jobs as mergeable 😮 🤦
This pr forces the run of the post job, which will fail if any of the previous jobs has failed or skipped
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!