Skip to content

Run always validate post-job #8122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented May 2, 2022

To make mergify not merge prs with failing validate jobs
If a main validate job fails github marks as skipped the rest of workflow jobs.
Otoh mergify considers prs with skipped required jobs as mergeable 😮 🤦

This pr forces the run of the post job, which will fail if any of the previous jobs has failed or skipped


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@jneira jneira requested review from andreabedini and Mikolaj May 2, 2022 19:57
Copy link
Collaborator

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by Mergify behaviour. Let's hope this fixes it.

@andreasabel
Copy link
Member

Before this PR can be merged, the workflow Validate windows-latest ghc-8.10.7 needs to be fixed, to satisfy self-application:

... not merge prs with failing validate jobs

;-)

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. But I'm confused by the CI failure.

@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 4, 2022

rebase

✅ Branch has been successfully rebased

@jneira jneira force-pushed the run-always-post-job branch from 85d36d3 to 5b8548e Compare May 4, 2022 10:46
@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2022

Oh, I see @jneira has spotted the same problem already here: #8120 (comment)

@jneira
Copy link
Member Author

jneira commented May 4, 2022

well, I think we have to merge this asap to avoid more bad merges
this change is good precisely cause it makes ci fail
but other prs could add more errors

@jneira
Copy link
Member Author

jneira commented May 4, 2022

then we have to tackle the cause of the error, I think the pr bumping versions was

To make mergify not merge prs with failing validate jobs
@jneira jneira force-pushed the run-always-post-job branch from 5b8548e to 1ff106b Compare May 4, 2022 19:24
@jneira
Copy link
Member Author

jneira commented May 4, 2022

then we have to tackle the cause of the error, I think the pr bumping versions was

we have a succesul run in master after the pr so it probably will not be: https://github.com/haskell/cabal/actions/runs/2268699392

@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2022

I agree, let's merge. We won't forget to fix the failing tests, because they are failing. Oh, wait, CI passed right now, after a rebase.

???

@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2022

And here it's now reported good even without a rebase: #8109

@jneira jneira merged commit 9b2ba1e into haskell:master May 5, 2022
@jneira
Copy link
Member Author

jneira commented May 5, 2022

yeah, the error has been transient, so maybe due to a bad cache 🤷
in any case this pr will prevent merging prs with failing ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants