This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Clear search string on quickjump hide for #781 #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jack, maybe #783 is also interesting for you? It will involve a small haskell patch this time. |
|
Looks sensible enough to me. |
|
@alexbiehl I was looking into that one, as well. I have a couple of ideas about it, so I’ll try to get a patch together if no one beats me to it. :) |
|
Nice, looking forward to it! Merging this one for now. |
sjakobi
pushed a commit
to sjakobi/haddock
that referenced
this pull request
Jun 10, 2018
(cherry picked from commit 59812a0)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's too aggressive to reset the search string every time the quickjump is hidden, so I'm happy to change it if it's too much.