Skip to content

hls-test-utils-1.0.0.0 doesn't build with hspec-core 2.8 #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felixonmars opened this issue May 15, 2021 · 4 comments · Fixed by #1837 or #2721
Closed

hls-test-utils-1.0.0.0 doesn't build with hspec-core 2.8 #1835

felixonmars opened this issue May 15, 2021 · 4 comments · Fixed by #1837 or #2721
Labels
CI Continuous integration old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@felixonmars
Copy link
Contributor

Your environment

Which OS do you use:
Arch Linux x86_64

Steps to reproduce

Build hls-test-utils 1.0.0.0 with hspec-core 2.8

Actual behaviour

Configuring hls-test-utils-1.0.0.0...
Preprocessing library for hls-test-utils-1.0.0.0..
Building library for hls-test-utils-1.0.0.0..
[1 of 2] Compiling Test.Hls.Util    ( src/Test/Hls/Util.hs, dist/build/Test/Hls/Util.dyn_o )

src/Test/Hls/Util.hs:188:32: error:
    ‘configOutputFile’ is not a (visible) constructor field name
    |
188 |                              , configOutputFile = Right $ subdir </> "results.xml"
    |                                ^^^^^^^^^^^^^^^^

It was removed in hspec/hspec@86ad5be#diff-f0f01b0b2162c19117bc77a50a8986ec24c6553b1e09c83213cac5c6760b270f
@jneira jneira added CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels May 15, 2021
@jneira
Copy link
Member

jneira commented May 15, 2021

Thanks for point it out. So as first action we have to add an upper bound and make a hackage revision to make it buildable

@berberman
Copy link
Collaborator

Afaik getHspecFormattedConfig is no longer used, and only tactics plugin is using hspec in test suite. We should clear out hspec related things from hls-test-utils.

@jneira jneira mentioned this issue May 16, 2021
Merged
@jneira
Copy link
Member

jneira commented May 16, 2021 •
edited
Loading

Agree, but the upper bound an hackage revision will be needed. Could we open a new issue for the cleaning of hls-test-utils?

@jneira
Copy link
Member

jneira commented May 16, 2021

Revision done: https://hackage.haskell.org/package/hls-test-utils-1.0.0.0/revision/1.cabal

hololeap added a commit to hololeap/haskell-language-server that referenced this issue Feb 18, 2022
@hololeap
Remove getHspecFormattedConfig which is no longer used.
18b4045 
Bump hspec dependency

Closes: haskell#1835
Signed-off-by: hololeap <[email protected]>
@hololeap hololeap mentioned this issue Feb 18, 2022
Merged
hololeap added a commit to hololeap/haskell-language-server that referenced this issue Feb 18, 2022
@hololeap
Remove getHspecFormattedConfig which is no longer used
e733134 
Bump hspec dependency

Closes: haskell#1835
Signed-off-by: hololeap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
3 participants
@jneira @felixonmars @berberman