Skip to content

Remove getHspecFormattedConfig which is no longer used #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

hololeap
Copy link
Contributor

@hololeap hololeap commented Feb 18, 2022

Remove hspec dependency

Closes: #1835

Bump hspec dependency

Closes: haskell#1835
Signed-off-by: hololeap <[email protected]>
@hololeap hololeap marked this pull request as ready for review February 18, 2022 19:05
@hololeap hololeap requested a review from jneira as a code owner February 18, 2022 19:05
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I will take one fewer dependency any day!

@pepeiborra pepeiborra merged commit 78305f2 into haskell:master Feb 18, 2022
@hololeap
Copy link
Contributor Author

Thanks @pepeiborra although I was planning on rebasing to get rid of that fixup and change the commit message to:

Remove hspec dependency

Just FYI!

@hololeap
Copy link
Contributor Author

I should have switched back to a draft when I realized I could remove hspec instead of bumping it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hls-test-utils-1.0.0.0 doesn't build with hspec-core 2.8
2 participants