Avoid statically linking glibc - #2456
Closed
pepeiborra wants to merge 1 commit into
Closed
Conversation
pepeiborra
marked this pull request as draft
December 8, 2021 22:16
Collaborator
Author
|
Binaries build successfully but, as expected, don't work out of the box on an older CentOS 8 system: |
Member
|
I guessthis has been superseded by #2463 and can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2431 we shouldn't be linking
glibcstatically. Unfortunately it is not easy to select which C libraries are linked statically, so this change disables static linking altogether. This means that the binaries will have a bunch of runtime dependencies:The resulting binaries will fail to work in any of the dependencies above are missing or too old, e.g. in Linux systems older than the CI system (Ubuntu LTS 18), or in Linux systems with non-standard lib paths like NixOS.
The next step will be switching to binaries with statically linked
muslin place ofglibc. This can be done easily by building HLS in an Alpine Linux distribution. In fact the Gitlab CI already builds alpine binaries, so in principle all that needs to do is update the packaging scripts to reuse those binaries.