Build linux binaries in alpine container - #2463
Merged
Merged
Conversation
pepeiborra
force-pushed
the
alpine-check-build
branch
from
December 10, 2021 19:09
b693e63 to
b9d97de
Compare
jneira
reviewed
Dec 10, 2021
Member
|
@pepeiborra sorry for the stream of comments, i think my version works like this one (hitting the integer-gmp error) without deduplicating the jobs, feel free to use the bits you find interesting: |
pepeiborra
force-pushed
the
alpine-check-build
branch
4 times, most recently
from
December 11, 2021 09:50
43da1a5 to
0df9083
Compare
jneira
reviewed
Dec 11, 2021
pepeiborra
marked this pull request as ready for review
December 11, 2021 12:18
pepeiborra
force-pushed
the
alpine-check-build
branch
from
December 11, 2021 12:22
e967dc0 to
ce53d3d
Compare
jneira
approved these changes
Dec 11, 2021
jneira
left a comment
jneira
left a comment
Member
There was a problem hiding this comment.
lgtm, thanks for the change, let's hope we can close some issues related with static linking thanks to
This was referenced Dec 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortest path towards #2461
Moving to Gitlab CI binaries is still very much desirable but also much more work.