-
-
Notifications
You must be signed in to change notification settings - Fork 388
Adding name to not implemented placeholder errors #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding name to not implemented placeholder errors #2465
Conversation
Actually, I would prefer if the body of the unimplemented function was just a hole:
Could you change it to that instead? |
@pepeiborra Sure! My workflow actually depends on hitting the errors, so I'm guessing there's a 'defer-holes' kind of option to allow running. (Edit: Confirmed as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Couple of tests need to be updated, but otherwise it looks good to me.
@pepeiborra having some issues running the tests right now. I'll come back to this soon. |
Yep, consistently getting the test error. |
This is already fixed in #2740 |
It's nice to see what isn't implemented when you get an error.
When you use the
define
action on undefined names, you get something like this:But wouldn't it be nicer to see this?