Skip to content

Adding name to not implemented placeholder errors #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Adding name to not implemented placeholder errors #2465

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6599d8
adding error to not implemented placeholders
sordina Dec 11, 2021
9454756
changing to a hole after feedback
sordina Dec 11, 2021
2382cf2
Merge branch 'master' into lyndon/add-name-to-not-implemented-errors
sordina Dec 13, 2021
06c045f
Merge branch 'master' into lyndon/add-name-to-not-implemented-errors
Anton-Latukha Dec 13, 2021
800bba3
Merge branch 'master' into lyndon/add-name-to-not-implemented-errors
Anton-Latukha Dec 20, 2021
bcf5ad5
Merge branch 'master' into lyndon/add-name-to-not-implemented-errors
jneira Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghcide/src/Development/IDE/Plugin/CodeAction.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ newDefinitionAction IdeOptions{..} parsedModule Range{_start} name typ
, _start `isInsideSrcSpan` l]
, nextLineP <- Position{ _line = _line lastLineP + 1, _character = 0}
= [ ("Define " <> sig
, [TextEdit (Range nextLineP nextLineP) (T.unlines ["", sig, name <> " = error \"not implemented\""])]
, [TextEdit (Range nextLineP nextLineP) (T.unlines ["", sig, name <> " = _"])]
)]
| otherwise = []
where
Expand Down