fix: resolve fave/unfave cross-campaign collision and NoResultFound error#540
Open
ayushshukla1807 wants to merge 1 commit into
Open
fix: resolve fave/unfave cross-campaign collision and NoResultFound error#540ayushshukla1807 wants to merge 1 commit into
ayushshukla1807 wants to merge 1 commit into
Conversation
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #526, fixes #527.
Root cause:
fave()queriedFavoriteonly byentry_id + user, ignoringcampaign_id. If the same image appeared in two campaigns, it would find the fave from the other campaign and activate it -- creating a cross-campaign state collision.Fix: Scope the existence check to
campaign_idinfave(). Theround_entrylookup already happens anyway (for creating the new fave), so fetchingcampaign_idfrom it adds no extra query.Also fixed:
unfave()used.one()which raisesNoResultFoundif the fave was never created (e.g. due to a prior collision or partial state). Changed to.one_or_none()with an explicit guard -- unfaving something that is not faved is a no-op, not a 500 error.