fix: add database-level UniqueConstraint to Favorite model#553
Open
ayushshukla1807 wants to merge 1 commit into
Open
fix: add database-level UniqueConstraint to Favorite model#553ayushshukla1807 wants to merge 1 commit into
ayushshukla1807 wants to merge 1 commit into
Conversation
Collaborator
|
Why would a database level constraint be desirable exactly? Wouldnt if be sufficient to deal with it at the backend? Is this a pattern you see in existing code? |
Author
|
I saw some duplicate rows in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
UniqueConstraintto theFavoritemodel across theuser_id,entry_id, andcampaign_idcolumns.Why:
In a previous fix (#540), we discovered that favorites were leaking across campaigns because they were only scoped to
user+entry. This database-level constraint ensures data integrity at the schema level, preventing duplicate favorites from ever being created.Impact:
Favoriterows in the database.This resolves the underlying database task mentioned in Issue #541.