-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Squeezebox add query and sync #31748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squeezebox add query and sync #31748
Conversation
|
Please, update the documentation and open a PR for it (be sure to create a documentation PR against the 🏷 I am adding the |
|
The doc pull request has been approved (home-assistant/home-assistant.io#12067). Can we remove the docs-missing label? |
|
Sorry, I'm new to this. Is there anything left I need to do for this change to be reviewed and accepted? |
|
We have quite a high workload on the PR's. Patience is what it would take at this point. Feel free to help out lowering our review workload by reviewing other PR's! Thanks! 👍 |
8e9711f to
690a6dd
Compare
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged when build passes.
|
Please extend the docs with the new services and link the docs PR in this PR description: https://www.home-assistant.io/integrations/squeezebox/#service-call_method |
|
This is the previously-approved docs PR: home-assistant/home-assistant.io#12067. Please let me know if I am missing something else I should add. Still new to this. |
|
We should just link it in the PR description up top, since that's where we look. |
Proposed change
Add a new service, call_query, which stores the results of a query against the Logitech Media Server database in a player attribute. Useful for searching for music stored in the Squeezebox library, for example if creating a Dialogflow integration to load music into the playlist.
In addition, add the ability to synchronize players. This is accomplished through two new services, sync and unsync.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: