Skip to content

Conversation

@rajlaud
Copy link
Contributor

@rajlaud rajlaud commented Feb 12, 2020

Proposed change

Add a new service, call_query, which stores the results of a query against the Logitech Media Server database in a player attribute. Useful for searching for music stored in the Squeezebox library, for example if creating a Dialogflow integration to load music into the playlist.

In addition, add the ability to synchronize players. This is accomplished through two new services, sync and unsync.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Contributor

Hi @rajlaud,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@frenck
Copy link
Member

frenck commented Feb 12, 2020

⚠️ I was unable to find a documentation PR (matching this code change) in our documentation repository.

Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.

🏷 I am adding the docs-missing label until this has been resolved.

@rajlaud
Copy link
Contributor Author

rajlaud commented Feb 16, 2020

The doc pull request has been approved (home-assistant/home-assistant.io#12067). Can we remove the docs-missing label?

@rajlaud
Copy link
Contributor Author

rajlaud commented Mar 19, 2020

Sorry, I'm new to this. Is there anything left I need to do for this change to be reviewed and accepted?

@frenck
Copy link
Member

frenck commented Mar 19, 2020

We have quite a high workload on the PR's. Patience is what it would take at this point. Feel free to help out lowering our review workload by reviewing other PR's! Thanks! 👍

@MartinHjelmare MartinHjelmare self-assigned this Apr 19, 2020
@rajlaud rajlaud mentioned this pull request Apr 26, 2020
20 tasks
@rajlaud rajlaud force-pushed the squeezebox-add-query-and-sync branch from 8e9711f to 690a6dd Compare April 28, 2020 16:09
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

@MartinHjelmare
Copy link
Member

Please extend the docs with the new services and link the docs PR in this PR description:

https://www.home-assistant.io/integrations/squeezebox/#service-call_method

@rajlaud
Copy link
Contributor Author

rajlaud commented Apr 29, 2020

This is the previously-approved docs PR: home-assistant/home-assistant.io#12067. Please let me know if I am missing something else I should add. Still new to this.

@MartinHjelmare
Copy link
Member

We should just link it in the PR description up top, since that's where we look.

@cgarwood cgarwood merged commit dbf383f into home-assistant:dev May 4, 2020
@lock lock bot locked and limited conversation to collaborators May 5, 2020
@rajlaud rajlaud deleted the squeezebox-add-query-and-sync branch June 24, 2020 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artwork not updating in re-factored squeezebox.

5 participants