-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Bump python-synology to 0.8.0 + Fix disk space incorrect sensor type #35068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-synology to 0.8.0 + Fix disk space incorrect sensor type #35068
Conversation
|
Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration ( |
|
I am actually not sure if this is a breaking change, can you tell me @bdraco ? Maybe HA interpolate "4.1 Tb" to "4.1", because HA is showing a graph, and not a line (like the Nice values in the "history" panel too. If not breaking change, should be added to 0.109.X |
|
@Quentame I'd class it as a bugfix to fix the missing units on disk space used. |
|
Ok, changing |
bdraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…35068) * Fix Synology disk space incorrect sensor type * Review 1



Proposed change
Bump python-synology to 0.8.0:
volume_size_total+volume_size_usedare numbers with always TeraBytes as unit.Release notes : https://github.com/ProtoThis/python-synology/releases/tag/0.8.0
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: