Skip to content

Conversation

@Quentame
Copy link
Member

@Quentame Quentame commented May 2, 2020

Proposed change

Bump python-synology to 0.8.0:

volume_size_total + volume_size_used are numbers with always TeraBytes as unit.

Release notes : https://github.com/ProtoThis/python-synology/releases/tag/0.8.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Quentame Quentame requested a review from bdraco May 2, 2020 17:41
@Quentame
Copy link
Member Author

Quentame commented May 2, 2020

I am actually not sure if this is a breaking change, can you tell me @bdraco ?

Before
image

After
image

Maybe HA interpolate "4.1 Tb" to "4.1", because HA is showing a graph, and not a line (like the sun sensor), and good values in the graph.

Nice values in the "history" panel too.

If not breaking change, should be added to 0.109.X

@bdraco
Copy link
Member

bdraco commented May 2, 2020

@Quentame I'd class it as a bugfix to fix the missing units on disk space used.

@Quentame
Copy link
Member Author

Quentame commented May 2, 2020

Ok, changing

@Quentame Quentame added this to the 0.109.3 milestone May 2, 2020
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-05-02 at 1 02 45 PM

Verified working

@Quentame Quentame merged commit e602de5 into home-assistant:dev May 2, 2020
@Quentame Quentame deleted the synology_dsm/fix-sensor-unit branch May 2, 2020 18:31
balloob pushed a commit that referenced this pull request May 2, 2020
…35068)

* Fix Synology disk space incorrect sensor type

* Review 1
@balloob balloob mentioned this pull request May 2, 2020
@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect sensor type in synology_dsm integration Synology DSM discovery: flow unique_id issue?

4 participants