Skip to content

ci: skip release-please version-bump PRs in checks #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onedr0p merged 1 commit into from
Jul 25, 2026
Merged

ci: skip release-please version-bump PRs in checks #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
name: E2E

on:
push:
branches:
- main
paths-ignore:
- "**.md"
- ".release-please-manifest.json"
pull_request:
branches:
- main
Expand All @@ -26,6 +20,9 @@ permissions:

jobs:
helm-e2e:
if: >-
Comment on lines 22 to +23

@greptile-apps greptile-apps Bot Jul 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Internal branch prefix bypasses checks

When a contributor creates a same-repository branch named release-please--*, this condition skips the job despite the pull request not being generated by release-please, causing Helm E2E, both lint jobs, and both test jobs to be bypassed across the three workflows.

Fix in Claude Code

${{ !(startsWith(github.head_ref, 'release-please--')
&& github.event.pull_request.head.repo.full_name == github.repository) }}
name: Helm E2E (kind)
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Resolved
runs-on: ubuntu-24.04
timeout-minutes: 15
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ permissions:

jobs:
lint:
if: >-
${{ !(startsWith(github.head_ref, 'release-please--')
&& github.event.pull_request.head.repo.full_name == github.repository) }}
name: Go Lint
runs-on: ubuntu-24.04
permissions:
Expand Down Expand Up @@ -53,6 +56,9 @@ jobs:
run: mise run lint

helm-lint:
if: >-
${{ !(startsWith(github.head_ref, 'release-please--')
&& github.event.pull_request.head.repo.full_name == github.repository) }}
name: Helm Lint
runs-on: ubuntu-24.04
permissions:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ env:

jobs:
test:
if: >-
${{ !(startsWith(github.head_ref, 'release-please--')
&& github.event.pull_request.head.repo.full_name == github.repository) }}
name: Go Tests
runs-on: ubuntu-24.04
permissions:
Expand Down Expand Up @@ -58,6 +61,9 @@ jobs:
run: mise run test

helm-unittest:
if: >-
${{ !(startsWith(github.head_ref, 'release-please--')
&& github.event.pull_request.head.repo.full_name == github.repository) }}
name: Helm Unit Tests
runs-on: ubuntu-24.04
permissions:
Expand Down
Loading