Repository navigation
ci: skip release-please version-bump PRs in checks - #48
Conversation
Greptile SummaryThis PR narrows validation skipping to same-repository release-prefixed pull requests and removes the post-merge E2E trigger.
|
| Filename | Overview |
|---|---|
| .github/workflows/e2e.yaml | Removes push-triggered E2E and adds a same-repository branch-prefix guard that still allows internal branches to bypass E2E. |
| .github/workflows/lint.yaml | Adds the same forgeable same-repository branch-prefix guard to both lint jobs. |
| .github/workflows/tests.yaml | Adds the same forgeable same-repository branch-prefix guard to both test jobs. |
Reviews (3): Last reviewed commit: "ci: skip automated release PRs; run e2e ..." | Re-trigger Greptile
2a5edcb to
7b0c7e0
Compare
Guard the check jobs so only genuine release-please PRs are skipped: the source branch starts with `release-please--` and the PR originates from this repo, not a fork. Ordinary and fork PRs still run every check. Also stop running e2e on push to main: a merged PR already ran e2e, so the post-merge run is redundant. e2e now runs on pull_request and workflow_dispatch. Signed-off-by: Devin Buhl <devin@buhl.casa>
7b0c7e0 to
c73f496
Compare
| helm-e2e: | ||
| if: >- |
There was a problem hiding this comment.
Internal branch prefix bypasses checks
When a contributor creates a same-repository branch named release-please--*, this condition skips the job despite the pull request not being generated by release-please, causing Helm E2E, both lint jobs, and both test jobs to be bypassed across the three workflows.
….2 ➔ 0.2.3) (#473) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-operations/charts/echo](https://github.com/home-operations/echo) | patch | `0.2.2` → `0.2.3` | --- ### Release Notes <details> <summary>home-operations/echo (ghcr.io/home-operations/charts/echo)</summary> ### [`v0.2.3`](https://github.com/home-operations/echo/blob/HEAD/CHANGELOG.md#023-2026-08-21) [Compare Source](home-operations/echo@0.2.2...0.2.3) ##### Bug Fixes - **chart:** keep example comments out of unrelated schema descriptions ([#​83](home-operations/echo#83)) ([6ce9ab2](home-operations/echo@6ce9ab2)) - **ci:** fail the merge gate on cancelled jobs, and key the lint cache on the toolchain ([#​58](home-operations/echo#58)) ([b4afcdd](home-operations/echo@b4afcdd)) - **go:** update module go (1.26.4 → 1.26.5) ([#​70](home-operations/echo#70)) ([8661ad5](home-operations/echo@8661ad5)) - **go:** update to go 1.27.0 ([#​84](home-operations/echo#84)) ([f9ba0a6](home-operations/echo@f9ba0a6)) ##### Documentation - add AGENTS.md with Go conventions ([#​62](home-operations/echo#62)) ([b218df4](home-operations/echo@b218df4)) - make AGENTS.md a generic, drift-resistant template ([#​64](home-operations/echo#64)) ([28d45d9](home-operations/echo@28d45d9)) ##### Build System - **mise:** add actionlint and refresh the lockfile ([#​50](home-operations/echo#50)) ([beda1ff](home-operations/echo@beda1ff)) ##### Continuous Integration - gate pull requests on a single Build Success check ([#​49](home-operations/echo#49)) ([8c394eb](home-operations/echo@8c394eb)) - **github-action:** Update action actions/stale (v10.4.0 → v11.0.0) ([#​59](home-operations/echo#59)) ([6255ec0](home-operations/echo@6255ec0)) - **github-action:** Update action docker/github-builder (v1.14.0 → v1.15.0) ([#​57](home-operations/echo#57)) ([25c7b5b](home-operations/echo@25c7b5b)) - **github-action:** Update action docker/github-builder (v1.15.0 → v1.16.0) ([#​73](home-operations/echo#73)) ([6fc568c](home-operations/echo@6fc568c)) - **github-action:** Update action docker/login-action (v4.5.1 → v4.5.2) ([#​60](home-operations/echo#60)) ([85c0d4d](home-operations/echo@85c0d4d)) - **github-action:** Update action docker/login-action (v4.5.2 → v4.6.0) ([#​63](home-operations/echo#63)) ([5cf5338](home-operations/echo@5cf5338)) - **github-action:** Update action home-operations/.github/actions/workflow-lint (v1.0.2 → v1.0.3) ([#​69](home-operations/echo#69)) ([42bac11](home-operations/echo@42bac11)) - **github-action:** Update action jdx/mise-action (v4.2.1 → v4.2.2) ([#​52](home-operations/echo#52)) ([c9298e0](home-operations/echo@c9298e0)) - **github-action:** Update action jdx/mise-action (v4.2.3 → v4.2.4) ([#​71](home-operations/echo#71)) ([5283840](home-operations/echo@5283840)) - **github-action:** Update github-actions ([#​53](home-operations/echo#53)) ([d6334ce](home-operations/echo@d6334ce)) - **github-action:** update workflow-lint action (1.0.0 → v1.0.2) ([#​66](home-operations/echo#66)) ([967c73a](home-operations/echo@967c73a)) - lint workflows with the shared composite action ([#​51](home-operations/echo#51)) ([c668830](home-operations/echo@c668830)) - skip release-please version-bump PRs in checks ([#​48](home-operations/echo#48)) ([2de44cc](home-operations/echo@2de44cc)) - wire govulncheck into mise and CI ([#​68](home-operations/echo#68)) ([2eb630c](home-operations/echo@2eb630c)) ##### Miscellaneous Chores - **github-action:** update action jdx/mise-action (v4.2.4 → v4.2.5) ([#​78](home-operations/echo#78)) ([d4e845d](home-operations/echo@d4e845d)) - **go:** pin go directive to 1.26.0 ([#​79](home-operations/echo#79)) ([88e2148](home-operations/echo@88e2148)) - **mise:** prune lockfile to used platforms ([#​67](home-operations/echo#67)) ([32591e5](home-operations/echo@32591e5)) - **mise:** Update tool cosign (3.1.2 → 3.1.3) ([#​74](home-operations/echo#74)) ([5edab8a](home-operations/echo@5edab8a)) - **mise:** update tool go (1.26.5 → 1.26.6) ([#​82](home-operations/echo#82)) ([9d4a187](home-operations/echo@9d4a187)) - **mise:** update tool go:golang.org/x/vuln/cmd/govulncheck (1.6.0 → v1.7.0) ([#​77](home-operations/echo#77)) ([731f12d](home-operations/echo@731f12d)) - **mise:** update tool helm (4.2.3 → 4.2.4) ([#​81](home-operations/echo#81)) ([32b85b4](home-operations/echo@32b85b4)) - **mise:** Update tool oxfmt (0.60.0 → 0.61.0) ([#​54](home-operations/echo#54)) ([d40cd22](home-operations/echo@d40cd22)) - **mise:** Update tool oxfmt (0.61.0 → 0.62.0) ([#​72](home-operations/echo#72)) ([5b7a778](home-operations/echo@5b7a778)) - **mise:** Update tool oxfmt (0.62.0 → 0.63.0) ([#​75](home-operations/echo#75)) ([7114dc7](home-operations/echo@7114dc7)) - **mise:** Update tool zizmor (1.28.0 → 1.29.0) ([#​65](home-operations/echo#65)) ([4ad14aa](home-operations/echo@4ad14aa)) - **release-please:** standardize the release pull request title pattern ([#​61](home-operations/echo#61)) ([d13101b](home-operations/echo@d13101b)) - standardize release-please changelog sections ([#​56](home-operations/echo#56)) ([007ec54](home-operations/echo@007ec54)) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Berlin) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4zMC4zIiwidXBkYXRlZEluVmVyIjoiNDQuMzAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9wYXRjaCJdfQ==--> Reviewed-on: https://git.xcd.dev/gabrielcosi/home-ops/pulls/473
Two changes, part of an org-wide CI conformity / minutes pass.
1. Skip only genuine release-please PRs, using a signal a contributor can't forge:
head_refalone (the PR's source branch name) is settable by anyone, including from a fork, so arelease-please--*branch could skip every check. Requiring the PR head repo to be this repo means fork PRs - the realistic path for outside contributors - always run the full suite.2. Run e2e on pull requests only. Dropped the
push: maintrigger: a merged PR already ran e2e, so the post-merge run was redundant. e2e now runs onpull_requestandworkflow_dispatch.