[tests] remove tf/flax tests in /generation
#36235
Conversation
|
|
||
| @pytest.mark.generate | ||
| @require_torch | ||
| class GenerationIntegrationTests(unittest.TestCase, GenerationIntegrationTestsMixin): |
There was a problem hiding this comment.
GenerationIntegrationTestsMixin contained integration tests shared across frameworks. They were moved here. A few redundant tests were removed in the process (e.g. max_new_tokens checks, which are part of the tests in GenerationTesterMixin)
There was a problem hiding this comment.
They were moved here
You mean those tests are moved to this class in this PR, right?
There was a problem hiding this comment.
Moved from GenerationIntegrationTestsMixin [deleted] to GenerationIntegrationTests , yes :)
gante
changed the title
/generation/generation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
OK, especially you have talked to the core maintainers!
Thanks
|
|
||
| @pytest.mark.generate | ||
| @require_torch | ||
| class GenerationIntegrationTests(unittest.TestCase, GenerationIntegrationTestsMixin): |
There was a problem hiding this comment.
They were moved here
You mean those tests are moved to this class in this PR, right?
3 participants
What does this PR do?
generatehas a few things that are shared across frameworks. Sometimes, when making core changes, we need to update all three frameworks. Otherwise, we get a red CI (example).Since we're deprecating TF/JAX, this PR removes their tests regarding
generateso that the other frameworks no longer hinder PT-relatedgeneratedevelopment.cc @LysandreJik @ArthurZucker as we chatted on Slack 🤗