[tests] remove pt_tf equivalence tests
#36253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
approved these changes
Feb 18, 2025
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
LGTM, but with a few nit questions. Thank you.
Are we going to remove pt_flax tests too?
tests/models/encoder_decoder/test_modeling_tf_encoder_decoder.py
Outdated
Show resolved
Hide resolved
tests/models/vision_encoder_decoder/test_modeling_tf_vision_encoder_decoder.py
Outdated
Show resolved
Hide resolved
Member
|
Happy to break the equivalence tests at this point! |
Contributor
Author
Yes, right after this PR gets merged 😎 (to avoid making a massive PR, which tend to lower the quality of the review process) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
Follows the same logic as in #36235: equivalence tests slow down development on the PT side.
In this particular case, this PR unblocks #36238: some models will start returning a
Cacheinstance by default, which breaks the equivalence tests on those models.cc @LysandreJik @ArthurZucker as we discussed on Slack; @Rocketknight1 fyi