[tests] remove flax-pt equivalence and cross tests #36283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Feb 19, 2025
| _run_pt_flax_cross_tests = parse_flag_from_env("RUN_PT_FLAX_CROSS_TESTS", default=True) | ||
| _run_custom_tokenizers = parse_flag_from_env("RUN_CUSTOM_TOKENIZERS", default=False) | ||
| _run_staging = parse_flag_from_env("HUGGINGFACE_CO_STAGING", default=False) | ||
| _tf_gpu_memory_limit = parse_int_from_env("TF_GPU_MEMORY_LIMIT", default=None) |
Contributor
Author
There was a problem hiding this comment.
TF_GPU_MEMORY_LIMIT is never set in our CI 👀
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
reviewed
Feb 19, 2025
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
works for me, just a few place with
if xxx:
pass
could/should be removed completely :-)
Contributor
Author
|
@ydshieh sorry, the same happened again 😅 the |
Contributor
Author
|
(@ydshieh not clear from your previous message -- if you're happy with the PR, I'll need an approval to merge 🤗 ) |
Collaborator
|
ohhhhh, I forgot the ✅ |
Contributor
Author
|
boom done :D |
pbielak
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 28, 2025
Following PR [1], the `is_pt_flax_cross_test` mark was removed. This commit applies the same changes for the `wav2vec` tests [2]. [1] huggingface/transformers#36283 [2] https://github.com/huggingface/transformers/pull/36283/files#diff-1063ef75ba73fe97fec48faf71f5020152ca85811784caaef74d4ca18fc6049f
pbielak
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 28, 2025
Following PR [1], the `is_pt_flax_cross_test` mark was removed. This commit applies the same changes for the `wav2vec` tests [2]. [1] huggingface/transformers#36283 [2] https://github.com/huggingface/transformers/pull/36283/files#diff-1063ef75ba73fe97fec48faf71f5020152ca85811784caaef74d4ca18fc6049f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #36253 -- removes FLAX-PT equivalence and cross-tests.
After this PR, I believe PT development should be mostly free from other frameworks :)
cc @LysandreJik @ArthurZucker as we discussed