Skip to content

Conversation

@Zeyi-Lin
Copy link
Contributor

@Zeyi-Lin Zeyi-Lin commented Mar 14, 2025

What does this PR do?

A tiny fix to make the curves displayed by the swanlab logger align with the actual steps, provide a better experience for developers

Before this PR, if you set logging_steps to 5, the points in the line chart on SwanLab would still be spaced 1 step apart (without passing the step parameter in swanlab.log) 💦; after the modification, the points are spaced 5 steps apart, consistent with logging_steps 🎉

image


This pull request includes a minor change to the logging functionality in the on_log method within the integration_utils.py file. The change ensures that the global step is included in the logging calls for better tracking and consistency.

Logging improvements:

@github-actions github-actions bot marked this pull request as draft March 14, 2025 16:27
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@Zeyi-Lin Zeyi-Lin marked this pull request as ready for review March 14, 2025 16:27
@Rocketknight1
Copy link
Member

cc @SunMarc @muellerzr @MekkCyber (feel free to yell at me if i should have pinged someone else)

@Zeyi-Lin
Copy link
Contributor Author

cc @SunMarc @muellerzr @MekkCyber (feel free to yell at me if i should have pinged someone else)

thanks! I updated my description in the comment to make the significance of this PR clearer 😄.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ArthurZucker ArthurZucker merged commit 8733297 into huggingface:main Mar 20, 2025
21 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants