Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A tiny fix to make the curves displayed by the
swanlablogger align with the actual steps, provide a better experience for developersBefore this PR, if you set
logging_stepsto 5, the points in the line chart on SwanLab would still be spaced 1 step apart (without passing thestepparameter inswanlab.log) 💦; after the modification, the points are spaced 5 steps apart, consistent withlogging_steps🎉This pull request includes a minor change to the logging functionality in the
on_logmethod within theintegration_utils.pyfile. The change ensures that the global step is included in the logging calls for better tracking and consistency.Logging improvements:
src/transformers/integrations/integration_utils.py: Modified theon_logmethod to include thestepparameter in calls toself._swanlab.logfor both single value scalars and non-scalar logs.