Skip to content

Fix swanlab global step #36728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 3 commits into from
Mar 20, 2025
Merged

Fix swanlab global step #36728

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ff63ae
fix
Zeyi-Lin Mar 14, 2025
0c2eefc
global step
Zeyi-Lin Mar 14, 2025
74327b8
Merge branch 'huggingface:main' into main
Zeyi-Lin Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/integrations/integration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2291,10 +2291,10 @@ def on_log(self, args, state, control, model=None, logs=None, **kwargs):
if state.is_world_process_zero:
for k, v in logs.items():
if k in single_value_scalars:
self._swanlab.log({f"single_value/{k}": v})
self._swanlab.log({f"single_value/{k}": v}, step=state.global_step)
non_scalar_logs = {k: v for k, v in logs.items() if k not in single_value_scalars}
non_scalar_logs = rewrite_logs(non_scalar_logs)
self._swanlab.log({**non_scalar_logs, "train/global_step": state.global_step})
self._swanlab.log({**non_scalar_logs, "train/global_step": state.global_step}, step=state.global_step)

def on_save(self, args, state, control, **kwargs):
if self._log_model is not None and self._initialized and state.is_world_process_zero:
Expand Down