Trigger CircleCI via GitHub Actions when ready for review
#37885
Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
ydshieh
changed the title
ready for review
| pull_request_target: | ||
| types: [ready_for_review] |
There was a problem hiding this comment.
We need to verify, when CircleCI use checkout, what is the head/commit being used for the runs.
Since pull_request_target could take effect only when the workflow file is on main, I can verify.
Once merged, I will check immediately.
| - run: if [[ "$CIRCLE_PULL_REQUEST" == "" && "$CIRCLE_BRANCH" != "main" && "$CIRCLE_BRANCH" != *-release ]]; then echo "Not a PR, not the main branch and not a release branch, skip test!"; circleci-agent step halt; fi | ||
| - run: 'curl -L -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME/pulls/${CIRCLE_PULL_REQUEST##*/} >> github.txt' | ||
| - run: git branch | ||
| - run: git log -n 1 |
There was a problem hiding this comment.
Just to make sure wheat is the commit. We can remove this once I see the correctness.
#37885)` (#38041) * check actions * trigger CI * check actions * finally --------- Co-authored-by: ydshieh <[email protected]>
…ace#37885) * update * update * update --------- Co-authored-by: ydshieh <[email protected]>
huggingface#37885)` (huggingface#38041) * check actions * trigger CI * check actions * finally --------- Co-authored-by: ydshieh <[email protected]>
What does this PR do?
So far we are using another approach that will prevent PRs from forked repositories not trigger CircleCI when
ready for review. This PRs try to use a GitHub Actions workflow withpull_request_review: ready_for_reviewthat will trigger CircleCI pipeline.