Repository navigation
[MiniCPMV4_6] Update test_small_model_vision_generation_batch expected output (value drift) - #48406
Merged
Merged
Conversation
…d output (value drift) Output drifted after #47625 refactored the Gated Delta Rule computation in `modeling_qwen3_5.py` (MiniCPMV4_6's text backbone). Verified by bisect: parent commit passes 3/3, the PR commit fails consistently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: minicpmv4_6 |
remi-or
approved these changes
Sep 1, 2026
remi-or
left a comment
remi-or
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Added the expectations for b200 as well.
Collaborator
|
run-slow: minicpmv4_6 |
Contributor
|
This comment contains models: ["models/minicpmv4_6"] |
Contributor
CI recapDashboard: View test results in Grafana |
Contributor
CI ResultsCommit Info
Model CI Report❌ 2 new failed tests from this PR 😭
|
This was referenced Sep 6, 2026
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Sep 16, 2026
…d output (value drift) (huggingface#48406) * [MiniCPMV4_6] Update test_small_model_vision_generation_batch expected output (value drift) Output drifted after huggingface#47625 refactored the Gated Delta Rule computation in `modeling_qwen3_5.py` (MiniCPMV4_6's text backbone). Verified by bisect: parent commit passes 3/3, the PR commit fails consistently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Added expectations for b200 --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: remi-or <remi.pierre_o@orange.fr> Co-authored-by: Rémi Ouazan <83456801+remi-or@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_small_model_vision_generation_batchstarted failing after #47625 refactored the Gated Delta Rule (GDR) computation inmodeling_qwen3_5.py. MiniCPMV4_6 usesQwen3_5as its text backbone, so the output drift propagates.Bisect result:
a8e8d144f6(parent of [Improvement] Make gated delta rule more explicit #47625): PASS × 383d46aa2a2([Improvement] Make gated delta rule more explicit #47625): FAIL consistentlyOutput diff:
"...also known as the Eurasian pystylus or snow leopard cat. It's a""...also known as a Pystylus cat or Eurasian pystylus. It"The drift is expected — #47625 is an intentional algorithmic improvement (UT transform baked in,
torch.linalg.solve_triangularreplacing the explicit loop, per-channel decay support), not a pure refactor.Fix
Update the hardcoded expected strings in
test_small_model_vision_generation_batchto match the new deterministic output.