Skip to content

[serge] Fix 2 integration tests regressed by commit 83d46aa2a2c4 (PR #47625) - #48580

Merged
tarekziade merged 1 commit into
mainfrom
serge/fix/itf-62b451006663-f800400a
Sep 7, 2026
Merged

tarekziade merged 1 commit into
mainfrom
serge/fix/itf-62b451006663-f800400a

Conversation

@sergereview

@sergereview sergereview Bot commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

CPU CI GPU run-slow

Original CI failure

  • Failure group: 2 integration tests regressed by commit 83d46aa2a2c4 (PR #47625)
  • tests/models/minicpmv4_6/test_modeling_minicpmv4_6.py::MiniCPMV4_6IntegrationTest::test_small_model_vision_generation_batch [multi-gpu] (output_mismatch, seen 7/7)
CI traceback — tests/models/minicpmv4_6/test_modeling_minicpmv4_6.py::MiniCPMV4_6IntegrationTest::test_small_model_vision_generation_batch
(line 505)  AssertionError: Lists differ: ['The animal in the image is a Pystylus, a[145 chars] It'] != ["The animal in the image is a Pystylus, a[161 chars]s a"]

Where to watch it:

The integration test test_small_model_vision_generation_batch regressed because the Qwen3.5 text-model changes in PR #47625 altered the generated text for this model. The actual decoded output now matches the previously separate ("cuda", 10) expectation, so the ("cuda", None) expected string is updated to the current model output.

Relates to #48579

Possibly related

Existing issues/PRs mentioning test_small_model_vision_generation_batch (keyword match — not verified to share a root cause):

  • #48406 — [MiniCPMV4_6] Update test_small_model_vision_generation_batch expected output (value drift) (PR, closed, updated 2026-09-01)

This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.

serge v0.1.0 · model: moonshotai/Kimi-K2.7-Code · 59 LLM turns · 63 tool calls · 83.2s · 2085622 in / 3934 out tokens

@sergereview
sergereview Bot marked this pull request as ready for review September 6, 2026 22:37
@sergereview
sergereview Bot requested a review from remi-or September 6, 2026 22:37
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: minicpmv4_6

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 34064564900:1
Result: success | Jobs: 2 | Tests: 21 | Failures: 0 | Duration: 2m 23s

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This again raises the issue of keeping a dependency list for multimodal models, so that when a backbone gets an update then all VLM/ALM that use it as backbone also trigger tests. And they are added in run-slow hint by the bot

I know YD mentioned it already, just re-raising in case it got lost :)

@tarekziade
tarekziade added this pull request to the merge queue Sep 7, 2026
@tarekziade

Copy link
Copy Markdown
Collaborator

This again raises the issue of keeping a dependency list for multimodal models, so that when a backbone gets an update then all VLM/ALM that use it as backbone also trigger tests. And they are added in run-slow hint by the bot

I know YD mentioned it already, just re-raising in case it got lost :)

cc @ydshieh for tracking

Merged via the queue into main with commit 299c538 Sep 7, 2026
41 checks passed
@tarekziade
tarekziade deleted the serge/fix/itf-62b451006663-f800400a branch September 7, 2026 09:01
@ydshieh

ydshieh commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

well, I don't even remember I mentioned this 😆 But good point

@ydshieh

ydshieh commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

The expected output values in this PR is incorrect.

The issue was originally fixed https://github.com/huggingface/transformers/pull/48406/changes, the correct value should be

"The animal in the image is a Pystylus, also known as a Pystylus cat or Eurasian pystylus. It",

@remi-or however introduced ("cuda", 10) and having some problems, so a new PR is opened #48454

but it's not merged before.

I will handle it. But @tarekziade what is the hardware type used by serge?

sbucaille pushed a commit to sbucaille/transformers that referenced this pull request Sep 16, 2026
…ngface#47625) (huggingface#48580)

Co-authored-by: serge[bot] <serge[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants