Repository navigation
Wait for each warmup forward before the next one rewrites the static inputs - #50353
Open
qgallouedec wants to merge 6 commits into
Open
qgallouedec wants to merge 6 commits into
qgallouedec wants to merge 6 commits into
Conversation
…inputs run_one_warmup prepared the next warmup size while the previous forward could still be running on the compute stream, so its kernels read inputs being rewritten. The KV paths were short enough to never show it; a model whose first layer reads cu_seq_lens, and whose forward is long enough, loses the race (Qwen3.5-0.8B with linear attention layers failed every warmup with an illegal address, the tiny test model never did).
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
run_one_warmupprepares the next warmup size while the previous warmup forward can still be running on the compute stream, so that forward's kernels read static inputs being rewritten. The KV paths were short enough never to show it; a model whose first layer readscu_seq_lensand whose forward is long enough loses the race: Qwen3.5-0.8B with the linear attention layers of #50350 failed every warmup with an illegal memory access, while the tiny test model never did. The fix waits for the compute stream after each warmup forward.Split out of #50350, which depends on it.