Skip to content

Wait for each warmup forward before the next one rewrites the static inputs #50353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qgallouedec wants to merge 6 commits into
base: main
Choose a base branch
from
+3 −0
Open

Wait for each warmup forward before the next one rewrites the static inputs #50353

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4bf54bc
Wait for each warmup forward before the next one rewrites the static …
qgallouedec Nov 4, 2026
79177f8
Merge remote-tracking branch 'origin/main' into tfu-50353
qgallouedec Nov 9, 2026
48a2f1a
Merge remote-tracking branch 'origin/main' into tfu-50353
qgallouedec Nov 10, 2026
8ac6f08
Merge branch 'main' into cb-warmup-sync
qgallouedec Nov 10, 2026
cef406e
Merge branch 'main' into cb-warmup-sync
qgallouedec Nov 12, 2026
f1ced78
Merge branch 'main' into cb-warmup-sync
qgallouedec Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/transformers/generation/continuous_batching/model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,9 @@ def run_one_warmup(self, model: nn.Module, num_q_tokens: int, max_kv_read: int |
batch_data["max_length_k"][allocator.layer_type] = max_length_k
io.max_length_k[allocator.layer_type] = max_length_k
self.compute_batch(model, batch_data)
# The next warmup rewrites the static inputs this forward reads, so wait for it to finish
if self.inputs_and_outputs.compute_stream is not None:
self.inputs_and_outputs.compute_stream.synchronize()
duration = time.perf_counter() - start
logger.debug(f"Warmup completed in {duration:.2f}s")

Expand Down
Loading