Repository navigation
Fix the default IS mode in the GRPOConfig docstring - #7751
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
approved these changes
Oct 15, 2026
albertvillanova
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Same stale default in the TIP at docs/source/grpo_trainer.md:221: "By default, Truncated Importance Sampling is activated". Since #4530 the default is sequence-level Masked IS. Could you fix it here too?
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
GRPOConfigdocstring labelstoken_truncateas the defaultvllm_importance_sampling_mode, but the default issequence_mask, as the field and the docstring header already say. This removes the stale label.Before submitting
AI writing disclosure
Note
Low Risk
Docstring-only change with no effect on code paths or configuration defaults.
Overview
Corrects a documentation-only mismatch in
GRPOConfig: thevllm_importance_sampling_modeenum list no longer marks"token_truncate"as the default.The actual default remains
"sequence_mask", as already stated on the parameter line and in the dataclass field. The"token_truncate"bullet is also lightly reworded (drops the stale “(default)” label and tightens the clipping range text).No runtime or training behavior changes.
Reviewed by Cursor Bugbot for commit e340667. Bugbot is set up for automated code reviews on this repo. Configure here.