Skip to content

Fix the default IS mode in the GRPO vLLM tip - #7800

Merged
albertvillanova merged 1 commit into
mainfrom
docs-grpo-is-default-tip
Oct 21, 2026
Merged

albertvillanova merged 1 commit into
mainfrom
docs-grpo-is-default-tip

Conversation

@sergiopaniego

@sergiopaniego sergiopaniego commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Follow-up to #7751, as suggested by @albertvillanova in the review: the vLLM TIP in grpo_trainer.md still says Truncated Importance Sampling is the default. Since #4530 the default vllm_importance_sampling_mode is sequence_mask, so the TIP now names it and links the Masked and Sequence-level IS sections of the paper index.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

AI writing disclosure

  • No AI usage: the PR was written entirely by a human.
  • AI-assisted: some parts were suggested or improved by AI, but the PR was written and reviewed by a human.
  • AI-generated: the PR was mostly or fully generated by an AI tool.

Since #4530 the default vllm_importance_sampling_mode is sequence_mask, not truncated IS. Follow-up to #7751 (suggested by @albertvillanova).
@github-actions github-actions Bot added the 📚 documentation Improvements or additions to documentation label Oct 19, 2026
@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
albertvillanova merged commit 591748e into main Oct 21, 2026
6 checks passed
@albertvillanova
albertvillanova deleted the docs-grpo-is-default-tip branch October 21, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants