Update TransformCollectionAndObjectInitializers to check for init-only properties#3678
Merged
siegfriedpammer merged 2 commits intoicsharpcode:masterfrom Mar 18, 2026
Merged
Conversation
4134411 to
a6b4824
Compare
Member
I couldn't find a definitive rule for when the Roslyn compiler uses local slots over stack slots. The main observation is that Roslyn prefers stack over locals especially in Release builds. Some of the things just cannot be tested in C# pretty tests so you may have to resort to IL pretty tests. |
a6b4824 to
e806d60
Compare
e806d60 to
dabfc75
Compare
siegfriedpammer
approved these changes
Mar 16, 2026
…ectInitializers.cs Co-authored-by: Siegfried Pammer <siegfried@pammer.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #3677
Solution
The main culprit was here:
Adding a simple check to see if the declaring type has init-only properties fixes the issue.
I would add a test that covers this, but I do not know how to force the C# compiler to allocate an object locally instead of on the stack consistently; if you have any tips, let me know.