Skip to content

Update TransformCollectionAndObjectInitializers to check for init-only properties #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siegfriedpammer merged 2 commits into from
Mar 18, 2026
+13 −0
Merged

Update TransformCollectionAndObjectInitializers to check for init-only properties #3678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dabfc75
Update TransformCollectionAndObjectInitializers to check for init-onl…
nikitalita Mar 15, 2026
4dc9969
Update ICSharpCode.Decompiler/IL/Transforms/TransformCollectionAndObj…
nikitalita Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ICSharpCode.Decompiler/IL/Transforms/TransformCollectionAndObjectInitializers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ void IStatementTransform.Run(Block block, int pos, StatementTransformContext con
{
case NewObj newObjInst:
if (newObjInst.ILStackWasEmpty && v.Kind == VariableKind.Local
&& !TypeContainsInitOnlyProperties(newObjInst.Method.DeclaringType.GetDefinition())
Comment thread
nikitalita marked this conversation as resolved.
Outdated
&& !currentMethod.IsConstructor
&& !currentMethod.IsCompilerGeneratedOrIsInCompilerGeneratedClass())
{
Expand Down Expand Up @@ -187,6 +188,18 @@ void IStatementTransform.Run(Block block, int pos, StatementTransformContext con
ILInlining.InlineIfPossible(block, pos, context);
}

private static bool TypeContainsInitOnlyProperties(ITypeDefinition? typeDefinition)
{
foreach (var property in typeDefinition?.Properties ?? [])
{
if (property.Setter?.IsInitOnly ?? false)
{
return true;
}
}
return false;
Comment thread
nikitalita marked this conversation as resolved.
}

internal static bool IsRecordCloneMethodCall(CallInstruction ci)
{
if (ci.Method.DeclaringTypeDefinition?.IsRecord != true)
Expand Down
Loading