-
-
Notifications
You must be signed in to change notification settings - Fork 377
feat: add options for theme toggle and language switching to the navbar #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi, this PR is really useful. What’s the status? Do you think we can get it merged before the v0.10 release? |
Hi, I do plan to implement this, but I’d like to take a different approach — componentizing the theme toggle and language switch (kinda similar to #534) instead of controlling their positions via fixed flags. This will require a bit more work. besides, language switches on the navbar can also be handled via navbar dropdown menu (implemented in #695) |
|
Looking forward to your implement, sound good for implementing them in component. |
Got it, thanks for the update! Looking forward to seeing it. |



Fix #654
displayThemeToggleanddisplayLanguageSwitchparameters inparams.navbardisplayThemeToggleis true, hide footer and sidebar theme toggle and only show navbar toggledisplayLanguageSwitchis true, hide footer and sidebar language switch button and only show navbar language switch button