-
-
Notifications
You must be signed in to change notification settings - Fork 377
feat: child menu support in navbar #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added a new JavaScript file for handling dropdown functionality in the navbar. - Implemented event listeners for toggling dropdowns, closing them on outside clicks, and dismissing with the Escape key. - Updated navbar HTML to support dropdown items with children, enhancing the navigation experience. - Adjusted core script imports to include the new dropdown functionality.
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements child menu support in the main navbar and updates related configurations. Key changes include adding a new navbar dropdown script, refactoring the navbar template to support dropdowns for items with children, and updating menu configuration and translations.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| layouts/partials/scripts/core.html | Enqueued the new navbar-dropdown.js script for handling dropdown logic. |
| layouts/partials/navbar.html | Added markup for dropdown menus on nav items with children. |
| exampleSite/i18n/zh-cn.yaml, ja.yaml, fa.yaml | Added translations for the new menu identifiers. |
| exampleSite/hugo_stats.json | Updated stats to include new CSS class references. |
| exampleSite/hugo.yaml | Updated menu configuration to include versions and child items. |
| assets/js/navbar-dropdown.js | Introduced a new JS module to manage dropdown behavior in the navbar. |
In
hugo.yamldefine:Replaces PR: #221
closes #224
closes #516