IWF-687 include full stacktrace when filename not found #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-give
requested review from
ktrops,
lwolczynski,
mixydubs,
samuel27m and
steven-rg-harrison
samuel27m
reviewed
Apr 1, 2025
iwf/worker_service.py
Outdated
| """ | ||
| stacktrace = traceback.format_exc() | ||
| index = stacktrace.index("iwf-python-sdk/iwf/worker_service.py") | ||
| index = stacktrace.find("iwf-python-sdk/iwf/worker_service.py") |
Member
There was a problem hiding this comment.
Could be this, to avoid the if statement?
Suggested change
| index = stacktrace.find("iwf-python-sdk/iwf/worker_service.py") | |
| index = max(0, stacktrace.find("iwf-python-sdk/iwf/worker_service.py")) |
samuel27m
approved these changes
Apr 1, 2025
samuel27m
approved these changes
Apr 1, 2025
lwolczynski
reviewed
Apr 1, 2025
| index = stacktrace.index("iwf-python-sdk/iwf/worker_service.py") | ||
| index = max(0, stacktrace.find("iwf-python-sdk/iwf/worker_service.py")) | ||
| return "WorkerExecutionError: {0}; StackTrace:{1}".format( | ||
| exception, stacktrace[index:] |
Contributor
There was a problem hiding this comment.
Does this mean full stacktrace will be returned if no iwf-python-sdk/iwf/worker_service.py found?
Contributor
Author
There was a problem hiding this comment.
That's correct. find will return -1 if the file isn't found, so use 0, and the string slice will include the full stacktrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #78