Skip to content

IWF-687 include full stacktrace when filename not found #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

IWF-687 include full stacktrace when filename not found #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a11740f
IWF-687 include full stacktrace when filename not found
Apr 1, 2025
24a3e7c
IWF-687 avoid `if` statement
Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iwf/worker_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def internal_error(exception):
return _worker_service.handle_worker_error(exception), 500
"""
stacktrace = traceback.format_exc()
index = stacktrace.index("iwf-python-sdk/iwf/worker_service.py")
index = max(0, stacktrace.find("iwf-python-sdk/iwf/worker_service.py"))
return "WorkerExecutionError: {0}; StackTrace:{1}".format(
exception, stacktrace[index:]
Copy link
Contributor

@lwolczynski lwolczynski Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean full stacktrace will be returned if no iwf-python-sdk/iwf/worker_service.py found?

Copy link
Contributor Author

@N-give N-give Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. find will return -1 if the file isn't found, so use 0, and the string slice will include the full stacktrace.

)
Expand Down