fix: change parser peerDep to >=6 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint/parser is now up to version 8, and it seems likely that this plugin will continue working with future versions, so my proposal is just to make the peerDep >= 6. Alternately, I'd be happy to change it to just add `|| ^8`
c100k
reviewed
Sep 9, 2024
| @@ -85,7 +85,7 @@ | |||
| "typescript": "5.1.6" | |||
| }, | |||
| "peerDependencies": { | |||
| "@typescript-eslint/parser": "^6 || ^7", | |||
| "@typescript-eslint/parser": ">=6", | |||
There was a problem hiding this comment.
I'm not a maintainer of this package, but as you suggested in the PR description, it's probably better to use || ^8 to avoid any weird behavior with a potential v9 that could break it "silently" in the future.
Besides, I've been testing it on v8 for a while, and it works well.
There was a problem hiding this comment.
it doesn't seem like this module is in active maintenance, which is why I'd prefer to have >=6 - that at least leaves clients in control of the situation instead of requiring more changes
There was a problem hiding this comment.
(BTW I am not at all trying to shame for it not being actively maintained, I know what I'm paying for it and am glad it's around)
infctr
approved these changes
Oct 5, 2024
|
resolves #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint/parser is now up to version 8, and it seems likely that this plugin will continue working with future versions, so my proposal is just to make the peerDep >= 6.
Alternately, I'd be happy to change it to just add
|| ^8(I have done no testing to ensure that version 8 does not actually break anything)