Skip to content

fix: change parser peerDep to >=6 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2024
Merged

fix: change parser peerDep to >=6 #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"typescript": "5.1.6"
},
"peerDependencies": {
"@typescript-eslint/parser": "^6 || ^7",
"@typescript-eslint/parser": ">=6",
Copy link

@c100k c100k Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer of this package, but as you suggested in the PR description, it's probably better to use || ^8 to avoid any weird behavior with a potential v9 that could break it "silently" in the future.

Besides, I've been testing it on v8 for a while, and it works well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem like this module is in active maintenance, which is why I'd prefer to have >=6 - that at least leaves clients in control of the situation instead of requiring more changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(BTW I am not at all trying to shame for it not being actively maintained, I know what I'm paying for it and am glad it's around)

"eslint": "^7 || ^8",
"typescript": "^3 || ^4 || ^5"
},
Expand Down