Skip to content

feat(backup): backup data and metadata #15558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(backup): backup data and metadata #15558

wants to merge 2 commits into from

Conversation

jacobmarble
Copy link
Contributor

@jacobmarble jacobmarble commented Oct 23, 2019 •
edited
Loading

Fixes #15603
Fixes #15604
Currently blocked on #15961

This command backs up data and metadata:

$ influx backup --path backup_dir

@jacobmarble jacobmarble force-pushed the jgm-backup-spike branch 4 times, most recently from 59c104c to cb5739f Compare November 11, 2019 23:33
@jacobmarble
Copy link
Contributor Author

@stephanie-engel data and meta data should backup properly now.

TODO(jacobmarble): auth checks should block any token without permission to read all data and all metadata

@jacobmarble jacobmarble force-pushed the jgm-backup-spike branch 2 times, most recently from 9e42faa to edbe453 Compare November 12, 2019 03:00
@jacobmarble jacobmarble changed the title feat(backup): initial backup spike feat(backup): backup data and metadata Nov 13, 2019
@jacobmarble jacobmarble requested a review from a team November 13, 2019 18:07
@jacobmarble jacobmarble requested review from e-dard and dgnorton and removed request for a team November 13, 2019 18:09
e-dard
e-dard suggested changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking super good! Just a bunch of mainly small things. I would love to see some exercising of the b/r path. That is... Write some data and snapshot it, then restore it to a location via the HTTP API.

The other thing that's missing with this feature is the user-facing documentation, but that can wait for another day. Great job 👍

dgnorton
dgnorton reviewed Nov 19, 2019
View reviewed changes
e-dard
e-dard approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the question about handling the engine closing 👍

@jacobmarble
Copy link
Contributor Author

This PR should not be merged until @russorat and I settle on a better authorization strategy.

@russorat
Copy link
Contributor

russorat commented Dec 4, 2019

this cannot be merged until we fix the issues with auth. using a master token gives the error: Error: read:notificationRules is unauthorized and using an All Access token gives the error: Error: read:authorizations is unauthorized.

@imogenkinsman imogenkinsman mentioned this pull request Dec 4, 2019
Closed
@jacobmarble
Copy link
Contributor Author

Squashed and rebased to master.

@jacobmarble
Copy link
Contributor Author

Replaced by #16504

@jacobmarble jacobmarble deleted the jgm-backup-spike branch January 11, 2020 00:01
@jacobmarble jacobmarble mentioned this pull request Jan 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgnorton dgnorton dgnorton approved these changes

@e-dard e-dard e-dard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage 2.0: implement meta data backup storage 2.0: implement data backup
4 participants
@jacobmarble @russorat @dgnorton @e-dard