ci: Install torch before flash-attn #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI because the workflow uses pull_request_target, the change doesn't apply in CI, hence the failure. |
This is to work around an issue in flash-attn build definition. The
issue manifests itself as:
```
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
Traceback (most recent call last):
File "<string>", line 2, in <module>
File "<pip-setuptools-caller>", line 34, in <module>
File "/tmp/pip-install-u40hct41/flash-attn_36e9333b3570426a854895a477ce846d/setup.py", line 22, in <module>
import torch
ModuleNotFoundError: No module named 'torch'
[end of output]
```
See: Dao-AILab/flash-attention#958
Signed-off-by: Ihar Hrachyshka <[email protected]>
booxter
force-pushed
the
flash-attn-hack
branch
from
d8c63ce to
09cd936
Compare
RobotSail
approved these changes
Apr 16, 2025
JamesKunstle
approved these changes
Apr 16, 2025
Contributor
Author
|
This fix was not enough: https://github.com/instructlab/training/actions/runs/14544214224/job/40807419095?pr=479 Trying to complete it in #482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work around an issue in flash-attn build definition. The
issue manifests itself as:
See: Dao-AILab/flash-attention#958
Signed-off-by: Ihar Hrachyshka [email protected]