-
Notifications
You must be signed in to change notification settings - Fork 74
ci: Use tox-current-env to reuse prepared venv with torch #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@booxter Is the problem that this fixes only in CI? Or would the end user be expected to run tox in the same way (i.e. having a venv)?
|
@RobotSail until Dao-AILab/flash-attention#958 is merged (and they don't seem keen to do so for reasons that I don't agree with), every project that depends on flash-attn has to pre-install their build dependencies, particularly pytorch. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
d644d8e to
2d0ed54
Compare
|
Testing the change here: https://github.com/instructlab/training/actions/runs/14713551885 |
2d0ed54 to
25361bd
Compare
25361bd to
ee2403b
Compare
ee2403b to
e221dc8
Compare
|
(The more I patch this, the more I don't like it. But let's see how horrible the final "fix" would look like...) |
This is a completion of a workaround for flash-attn. The initial attempt didn't work because we still used tox to run smoke tests, which means another venv was created that did not include flash-attn. To achieve sharing the venv for both torch+ installation and smoke tests, we are using tox-current-env plugin here. Signed-off-by: Ihar Hrachyshka <[email protected]>
e221dc8 to
926fbfe
Compare
|
This run confirms that tox-current-env works now: https://github.com/instructlab/training/actions/runs/14719818289/job/41311408922 Now to decide if we want to see this solution. (If not, I'm all ears to hear about alternatives that would allow us to run smoke tests with |
This is a completion of a workaround for flash-attn. The initial attempt didn't work because we still used tox to run smoke tests, which means another venv was created that did not include flash-attn.
To achieve sharing the venv for both torch installation and smoke tests, we are using tox-current-env plugin here.