[opencl-aot][sycl][CMake][MSVC]: Wrap Linker flags for ICX #15756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From CMake 3.25+ linker options need to be wrapped for ICX on Windows. Use the `LINKER:` prefix, which expands to the correct option for ICX, and for the empty string for MSVC or clang-cl. See also LLVM RFC: https://discourse.llvm.org/t/rfc-cmake-linker-flags-need-wl-equivalent-for-intel-c-icx-on-windows/82446 Fixes: intel#15755
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-tools-reviewers |
AlexeySachkov
approved these changes
Oct 23, 2024
|
@intel/llvm-gatekeepers please merge. |
steffenlarsen
pushed a commit
that referenced
this pull request
Dec 12, 2024
This is a continuation of #15756 unfortunately I missed some flags in that patch because icx does not warn about options starting with `/O` or `/D` (they are understood as optimization and macro defining flags). I documented the approach of finding these unwrapped flags as a GH gist here: https://gist.github.com/Maetveis/00567488f0d6ff74095d91ed306fafc5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From CMake 3.25+ linker options need to be wrapped for ICX on Windows. Use the
LINKER:prefix, which expands to the correct option for ICX, and for the empty string for MSVC or clang-cl.See also LLVM RFC: https://discourse.llvm.org/t/rfc-cmake-linker-flags-need-wl-equivalent-for-intel-c-icx-on-windows/82446
Fixes: #15755