[CMake][MSVC] Wrap more Linker flags for ICX #16284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a continuation of intel#15756 unfortunately I missed some flags in that patch because icx does not warn about options starting with `/O` or `/D` (they are understood as optimization and macro defining flags). I documented the approach of finding these unwrapped flags as a GH gist here: https://gist.github.com/Maetveis/00567488f0d6ff74095d91ed306fafc5
cperkinsintel
approved these changes
Dec 6, 2024
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers can you merge please? |
|
ping @intel/llvm-gatekeepers again, this should work now with me in the org. |
|
Sorry this flew under the radar, @Maetveis! |
Maetveis
added a commit
to Maetveis/llvm
that referenced
this pull request
Jan 28, 2025
CMake's check_linker_flag does no split flags by spaces, so the current call passes the single option `"/OPT:REF LINKER:/OPT:ICF"` with a space in it to link.exe. (The first `LINKER:` prefix is parsed). This was also broken before ede906c ([CMake][MSVC] Wrap more Linker flags for ICX (intel#16284)), where it would pass `"/OPT:REF /OPT:ICF"` as a single option. This results in the check failing and so the build does not ever enable these flags, even though they would be supported if the check was correct. Use comma as the separator as supported by the `LINKER:` syntax to fix it.
steffenlarsen
pushed a commit
that referenced
this pull request
Jan 29, 2025
CMake's check_linker_flag does no split flags by spaces, so the current call passes the single option `"/OPT:REF LINKER:/OPT:ICF"` with a space in it to link.exe. (The first `LINKER:` prefix is parsed). This was also broken before ede906c ([CMake][MSVC] Wrap more Linker flags for ICX (#16284)), where it would pass `"/OPT:REF /OPT:ICF"` as a single option. This results in the check failing and so the build does not ever enable these flags, even though they would be supported if the check was correct. Use comma as the separator as supported by the `LINKER:` syntax to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #15756 unfortunately I missed some flags in that patch because icx does not warn about options starting with
/Oor/D(they are understood as optimization and macro defining flags).I documented the approach of finding these unwrapped flags as a GH gist here: https://gist.github.com/Maetveis/00567488f0d6ff74095d91ed306fafc5